Skip to content

Fix bugs in advantage computation#8

Merged
shuheng-liu merged 3 commits into
mainfrom
fix/compute-advantage
Dec 30, 2025
Merged

Fix bugs in advantage computation#8
shuheng-liu merged 3 commits into
mainfrom
fix/compute-advantage

Conversation

@shuheng-liu
Copy link
Copy Markdown
Member

  1. Use frame index instead of timestamp as advantage keys
  2. Ensure consistency with type hints during adv. computation
  3. Fix renamed arg name in calculate_n_step_return

@shuheng-liu shuheng-liu self-assigned this Dec 30, 2025
@shuheng-liu shuheng-liu added the bug Something isn't working label Dec 30, 2025
@shuheng-liu shuheng-liu requested review from WilliamYue37 and akshay18iitg and removed request for akshay18iitg December 30, 2025 19:51
@shuheng-liu shuheng-liu merged commit 51c31db into main Dec 30, 2025
0 of 6 checks passed
@WilliamYue37 WilliamYue37 deleted the fix/compute-advantage branch January 7, 2026 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant